Change Default Download URL and use HTTPS

The download URL appears to have moved as a lookup on the current URL returns two HTTP 301 responses and one HTTP 302. Using the HTTPS protocol to download JIRA may help protect users from MITM attacks, provided the staging and deploy modules ensure their underlying providers validate SSL certificates. Signed-off-by: Trevor Bramwell <[email protected]>
Pigueiras · Dec 11, 2015 · e6abab0 · e6abab0
1 parent 3eade3b
commit e6abab0
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -299,7 +299,7 @@ defaults to ''
 #####`$downloadURL`
 
 The URL used to download the JIRA installation file.
-Defaults to 'http://www.atlassian.com/software/jira/downloads/binary/'
+Defaults to 'https://downloads.atlassian.com/software/jira/downloads/'
 
 #####`$staging_or_deploy`
 

diff --git a/jira.yaml b/jira.yaml
@@ -93,7 +93,7 @@ jira::jvm_optional: -XX:-HeapDumpOnOutOfMemoryError
 # the New and SR figures are purely optional
 # for heap dumps add -XX:-HeapDumpOnOutOfMemoryError
 # by default jira has 256m permgen which is a good setting to go with
-jira::downloadURL: "http://www.atlassian.com/software/jira/downloads/binary/"
+jira::downloadURL: 'https://downloads.atlassian.com/software/jira/downloads/'
 
 # Should puppet manage this service
 #  Boolean dictating if puppet should manage the service

diff --git a/manifests/init.pp b/manifests/init.pp
@@ -88,7 +88,7 @@
   $java_opts    = '',
 
   # Misc Settings
-  $downloadURL           = 'http://www.atlassian.com/software/jira/downloads/binary/',
+  $downloadURL           = 'https://downloads.atlassian.com/software/jira/downloads/',
   $disable_notifications = false,
 
   # Choose whether to use nanliu-staging, or mkrakowitzer-deploy

diff --git a/spec/classes/jira_install_deploy_spec.rb b/spec/classes/jira_install_deploy_spec.rb
@@ -18,13 +18,15 @@
             :format      => 'tar.gz',
             :product     => 'jira',
             :version     => '6.4.3a',
-            :downloadURL => 'http://www.atlassian.com/software/jira/downloads/binary/',
+            :downloadURL => 'https://downloads.atlassian.com/software/jira/downloads/',
             :staging_or_deploy => 'deploy',
           }}
           it { should contain_group('jira') }
           it { should contain_user('jira').with_shell('/bin/true') }
           it 'should deploy jira 6.4.3a from tar.gz' do
-            should contain_deploy__file("atlassian-jira-6.4.3a.tar.gz")
+            should contain_deploy__file("atlassian-jira-6.4.3a.tar.gz").with(
+              'url' => 'https://downloads.atlassian.com/software/jira/downloads/',
+              )
           end
           it 'should manage the jira home directory' do
             should contain_file('/home/jira').with({

diff --git a/spec/classes/jira_install_staging_spec.rb b/spec/classes/jira_install_staging_spec.rb
@@ -19,13 +19,13 @@
             :format      => 'tar.gz',
             :product     => 'jira',
             :version     => '6.4.3a',
-            :downloadURL => 'http://www.atlassian.com/software/jira/downloads/binary',
+            :downloadURL => 'https://downloads.atlassian.com/software/jira/downloads',
           }}
           it { should contain_group('jira') }
           it { should contain_user('jira').with_shell('/bin/true') }
           it 'should deploy jira 6.4.3a from tar.gz' do
             should contain_staging__file("atlassian-jira-6.4.3a.tar.gz").with({
-              'source' => 'http://www.atlassian.com/software/jira/downloads/binary/atlassian-jira-6.4.3a.tar.gz',
+              'source' => 'https://downloads.atlassian.com/software/jira/downloads/atlassian-jira-6.4.3a.tar.gz',
               })
             should contain_staging__extract("atlassian-jira-6.4.3a.tar.gz").with({
               'target' => '/opt/jira/atlassian-jira-6.4.3a-standalone',