Avoid introducing breaking changes

With these changes, the issue can be fixed without breaking the API.
Pigueiras · Jul 6, 2021 · adc39eb · adc39eb
1 parent 664fd47
commit adc39eb
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -274,7 +274,7 @@
 
   # Jira Settings
   String $version                                                   = '8.13.5',
-  Enum['jira', 'servicedesk', 'jira-core'] $product                 = 'jira',
+  String[1] $product                                                = 'jira',
   Stdlib::Absolutepath $installdir                                  = '/opt/jira',
   Stdlib::Absolutepath $homedir                                     = '/home/jira',
   Boolean $manage_user                                              = true,
@@ -412,7 +412,8 @@
   Optional[Integer[0]] $poolsize                                    = undef,
   Optional[Boolean] $enable_connection_pooling                      = undef,
 ) {
-  if $product == 'jira' and versioncmp($jira::version, '8.0.0') < 0 {
+  // To maintain compatibility with previous behaviour, we check for not-servicedesk instead of specifying the 
+  if $product != 'servicedesk' and versioncmp($jira::version, '8.0.0') < 0 {
     fail('JIRA versions older than 8.0.0 are no longer supported. Please use an older version of this module to upgrade first.')
   }
   if $product == 'servicedesk' and versioncmp($jira::version, '4.10.0') < 0 {