Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle network errors #1516

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from
Open

Handle network errors #1516

wants to merge 26 commits into from

Conversation

varCepheid
Copy link
Collaborator

No description provided.

calebeby and others added 19 commits July 3, 2020 12:32
trying to fix issue 1480
from pull request #1057 

* Added a message for non-existent matches

* Tweaked how invalid match keys are identified

* Tidied up code and undid some changes

* addressed the review components

The lint and type checks are finding lots of errors I didn't put there, and they won't let the webpack run, so I haven't tested any of this. I'm not sure exactly how to fix all of those errors.

* error fixes

* fixed lint errors

* test fix?

* more test fixes

* fixed errors

* ran type and lint

* lint

* fixed Fragment error

* rebuilt the card that appears on non-existent match

* fixed normal match-page issues

* aesthetic, code-shortening, lint

* undo unneeded change

* undid bug-fix changes

* more reverting bug fixes

* attempted to differentiate between different kinds of errors NEEDS TO BE TESTED

* aesthetic changes

Co-authored-by: Alex <[email protected]>
Co-authored-by: Caleb Eby <[email protected]>
* ran build and fund

* made error card
* created a more impressive 404 page

* back-merged from handle-network-errors and configured the ErrorCard, still needs work that can be done on that branch --Elijah

* it works now... --Elijah

* slight adjustments to 404-error --Elijah

* aesthetic changes

* changed font styles for ErrorCard and 404-error --Elijah

Co-authored-by: var Cepheid <[email protected]>
* Added message for non-existant events

* Formatting for non-existent events

* Fixed styling errors for non-existent event pages and network error pages.

* made a few of the suggested changes

I couldn't get the webpack to work, so I'm not sure if these really solve the problems.

* error fixes & lint

* display a message if the event does not exist

The other changes involve fixing issues in the grid layout.

* switched error message to ErrorCard

* minor changes

Co-authored-by: var Cepheid <[email protected]>
@varCepheid varCepheid added enhancement Adds a new feature or meets a request. wip labels Jun 10, 2022
@varCepheid varCepheid self-assigned this Jun 10, 2022
@varCepheid varCepheid marked this pull request as draft June 10, 2022 22:10
@varCepheid varCepheid marked this pull request as ready for review June 10, 2022 23:14
@varCepheid varCepheid requested a review from calebeby June 10, 2022 23:14
@varCepheid varCepheid removed the wip label Jun 10, 2022
@calebeby
Copy link
Member

@varCepheid this is an intimidatingly large PR to review and test. Is it OK with you if I hold off on reviewing it until all the other open PRs get merged? That way we can avoid conflicts (even if they are not explicitly flagged by git) and make sure that everything gets tested in-depth.

@varCepheid
Copy link
Collaborator Author

Yes, that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds a new feature or meets a request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants