[P2] Attacks that miss against pokemon in semi invul state that have …

…abilities such as volt absorb will not trigger (pagefaultgames#4663)

* fixing issue where abilities trigger in semi invul state

* fixing targets

src/phases/move-effect-phase.ts

@@ -99,8 +99,9 @@ export class MoveEffectPhase extends PokemonPhase {
  const targetHitChecks = Object.fromEntries(targets.map(p => [ p.getBattlerIndex(), this.hitCheck(p) ]));
  const hasActiveTargets = targets.some(t => t.isActive(true));
 
- /** Check if the target is immune via ability to the attacking move */
- const isImmune = targets[0].hasAbilityWithAttr(TypeImmunityAbAttr) && (targets[0].getAbility()?.getAttrs(TypeImmunityAbAttr)?.[0]?.getImmuneType() === user.getMoveType(move));
+ /** Check if the target is immune via ability to the attacking move, and NOT in semi invulnerable state */
+ const isImmune = targets[0].hasAbilityWithAttr(TypeImmunityAbAttr) && (targets[0].getAbility()?.getAttrs(TypeImmunityAbAttr)?.[0]?.getImmuneType() === user.getMoveType(move))
+ && !targets[0].getTag(SemiInvulnerableTag);
 
  /**
  * If no targets are left for the move to hit (FAIL), or the invoked move is single-target
@@ -148,8 +149,9 @@ export class MoveEffectPhase extends PokemonPhase {
  && (hasConditionalProtectApplied.value || (!target.findTags(t => t instanceof DamageProtectedTag).length && target.findTags(t => t instanceof ProtectedTag).find(t => target.lapseTag(t.tagType)))
  || (this.move.getMove().category !== MoveCategory.STATUS && target.findTags(t => t instanceof DamageProtectedTag).find(t => target.lapseTag(t.tagType))));
 
- /** Is the pokemon immune due to an ablility? */
- const isImmune = target.hasAbilityWithAttr(TypeImmunityAbAttr) && (target.getAbility()?.getAttrs(TypeImmunityAbAttr)?.[0]?.getImmuneType() === user.getMoveType(move));
+ /** Is the pokemon immune due to an ablility, and also not in a semi invulnerable state? */
+ const isImmune = target.hasAbilityWithAttr(TypeImmunityAbAttr) && (target.getAbility()?.getAttrs(TypeImmunityAbAttr)?.[0]?.getImmuneType() === user.getMoveType(move))
+ && !target.getTag(SemiInvulnerableTag);
 
  /**
  * If the move missed a target, stop all future hits against that target

src/test/abilities/volt_absorb.test.ts

@@ -71,4 +71,23 @@ describe("Abilities - Volt Absorb", () => {
  await game.phaseInterceptor.to("BerryPhase", false);
  expect(enemyPokemon.hp).toBe(enemyPokemon.getMaxHp());
  });
+ it("regardless of accuracy should not trigger on pokemon in semi invulnerable state", async () => {
+ game.override.moveset(Moves.THUNDERBOLT);
+ game.override.enemyMoveset(Moves.DIVE);
+ game.override.enemySpecies(Species.MAGIKARP);
+ game.override.enemyAbility(Abilities.VOLT_ABSORB);
+
+ await game.classicMode.startBattle();
+
+ const enemyPokemon = game.scene.getEnemyPokemon()!;
+
+ game.move.select(Moves.THUNDERBOLT);
+ enemyPokemon.hp = enemyPokemon.hp - 1;
+ await game.setTurnOrder([ BattlerIndex.ENEMY, BattlerIndex.PLAYER ]);
+ await game.phaseInterceptor.to("MoveEffectPhase");
+
+ await game.move.forceMiss();
+ await game.phaseInterceptor.to("BerryPhase", false);
+ expect(enemyPokemon.hp).toBeLessThan(enemyPokemon.getMaxHp());
+ });
 });