Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image visibility #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LuD1161
Copy link
Contributor

@LuD1161 LuD1161 commented Sep 27, 2020

Current Implementation :

image

When clicking the image in modal, it looks like this :

image

After this PR :

image

When clicking the image in modal, it looks like this :

image

@PierreCapo
Copy link
Owner

Hello @LuD1161 thanks again for all of your PRs, that's super cool 😍
On this one, I'll need to test a bit more, since handling images in Tweets was particularly tricky. Typically, it needs also to handle properly both single and multiple images. I'll have a closer look in some hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants