Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hashivault module with AWS Secret Engine #18

Merged
merged 4 commits into from
May 17, 2023
Merged

feat: Hashivault module with AWS Secret Engine #18

merged 4 commits into from
May 17, 2023

Conversation

PierreBeucher
Copy link
Owner

No description provided.

@PierreBeucher PierreBeucher requested a review from teto May 15, 2023 08:56
@PierreBeucher
Copy link
Owner Author

May be risky if one load both aws.assume_role and hashivault.aws variables. Add warning to show duplicate vars

PierreBeucher and others added 2 commits May 15, 2023 12:07
@PierreBeucher
feat: Hashivault module with AWS Secret Engine
141e282
@PierreBeucher
chore: fix Localstack version
241009e 
tests were failing on GitHub because a different Localstack version was used (with a different behavior)
@PierreBeucher
Copy link
Owner Author

Will solve with https://github.com/novadiscovery/novops/issues/19

@PierreBeucher PierreBeucher merged commit 0c08873 into PierreBeucher:main May 17, 2023
@PierreBeucher PierreBeucher deleted the aws-se branch June 19, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PierreBeucher