Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python v1.0 #46

Merged
merged 16 commits into from
Jan 26, 2024
Merged

Python v1.0 #46

merged 16 commits into from
Jan 26, 2024

Conversation

mrrostam
Copy link
Contributor

No description provided.

@mrrostam mrrostam requested a review from bejager January 26, 2024 00:47
laves
laves requested changes Jan 26, 2024
View reviewed changes
Copy link
Member

@laves laves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I have some questions about the formatting that was applied

binding/python/_eagle.py Outdated Show resolved Hide resolved
binding/python/_factory.py Outdated Show resolved Hide resolved
@laves laves merged commit 26a8f93 into v1.0 Jan 26, 2024
48 checks passed
@laves laves deleted the v1.0-python branch January 26, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bejager bejager bejager approved these changes

@laves laves laves approved these changes

Assignees

@laves laves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrrostam @laves @bejager