Ignore type variable casts in ClassCastLambdaUsage check
#1449
Conversation
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
There was a problem hiding this comment.
Actually, it was @EnricSala who pointed this out 😉.
Added a suggestion :).
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
| @@ -48,7 +49,10 @@ public Description matchLambdaExpression(LambdaExpressionTree tree, VisitorState | |||
| } | |||
|
|
|||
| Type type = ASTHelpers.getType(typeCast); | |||
| if (type == null || type.isParameterized() || type.isPrimitive()) { | |||
| if (type == null | |||
There was a problem hiding this comment.
I'm confused now, was the pitest warning already here or is it new 🤔?
There was a problem hiding this comment.
AFAIK:
- It was in the original commit, pre suggestions.
- It was introduced with this PR, so it is probably referencing mutating the
#isPrimitivecall 🤔
There was a problem hiding this comment.
Thanks for checking @mohamedsamehsalah 🚀🚀🚀!
There was a problem hiding this comment.
Any clue why is this reported? 😅
There was a problem hiding this comment.
Any clue why is this reported? 😅
I re-read the warning line
A change can be made to line 52 without causing a test to fail
referncing mutating the nullability check; which seems like a common warning for similar PRs (for example, here).
Stephan202
force-pushed
the
mohamedsamehsalah/exclude-type-variables-in-class-cast-checker
branch
from
3dbc7fa to
79d807b
Compare
There was a problem hiding this comment.
Rebased and added a commit. Tnx @mohamedsamehsalah and @EnricSala!
Suggested commit message:
Ignore type variable casts in `ClassCastLambdaUsage` check (#1449)
@rickie I'll let you merge if you agree with the changes.
| /* | ||
| * The method reference syntax does not support casting to parameterized types. Additionally, | ||
| * `Class#cast` does not support the same range of type conversions between (boxed) primitive |
There was a problem hiding this comment.
We should update this comment.
| " private <T> void m2() {", | ||
| " Stream.of(11).map(i -> (T) i);", |
There was a problem hiding this comment.
We can add the type variable to m() instead.
Stephan202
changed the title
ClassCastLambdaUsage checkerClassCastLambdaUsage check
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
force-pushed
the
mohamedsamehsalah/exclude-type-variables-in-class-cast-checker
branch
from
79d807b to
fc3ecbd
Compare
|
Rebased, changes LGTM! |
|
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Stephan202
deleted the
mohamedsamehsalah/exclude-type-variables-in-class-cast-checker
branch
Thanks for pointing out @rickie 🙏
Suggested commit message