-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Dropwizard Metrics integration test #1426
Merged
Merged
Changes from 61 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
4ec0678
Initial metrics integration test
oxkitsune 11d02d4
Integration test script
oxkitsune d18dd8a
Use integration-test.sh in checkstyle
oxkitsune d7a3fbe
Use integration-test.sh relative to test dir
oxkitsune be6d3e5
Run metrics on java 17
oxkitsune 36f8b01
run metrics
oxkitsune 952451c
clarify reason for check exclusion
oxkitsune 2ebd530
add `additional_src_directories` flag
oxkitsune b6bed86
fix checkstyle integration test script
oxkitsune 3b2a0b4
add matrix to integration test workflow
oxkitsune 713853d
suggestions
oxkitsune 5825498
apply suggestions in init patch
oxkitsune 97989c6
trigger integration-test action
oxkitsune 4dcfb10
temporarily remove condition
oxkitsune 79931df
disable new checks as they cause errors
oxkitsune 4dafc7e
Post-rebase fix
rickie dddb602
Rename metrics files to drop the version
rickie 0417783
Style improvements
rickie 75eb8d2
Typo
rickie b9836c6
sync metrics
oxkitsune 78cac86
Only run on GH comment
rickie 1ff1d57
Try to trigger metrics
rickie 51ec7bc
Try to run both variants
rickie ee00181
Dont analyse generated files
rickie 8b4cba4
Fix metrics init patch
oxkitsune cc69b87
Try different refaster name patterns
oxkitsune f793c73
Merge `master` in this branch
rickie 1ac65e9
Fix missed merge conflicts
rickie 54f541a
Checkpoint
rickie 01a97f0
First full version!
rickie 2876cf8
ExcludePaths generated_resources
rickie 1a543bf
More cleanup, less init patch
rickie 78c264b
Simplify init patch further
rickie aacdbc5
Drop unnecessary args
rickie 7ab842a
Merge master again
rickie 1b9f735
Update error_prone_shared_flags
rickie ffcca9c
Introduce `shared_error_prone_flags`
rickie 3d557c0
Fix integration test setup
rickie 9359441
Cleanup
rickie 2a8e885
Merge branch 'master' into rossendrijver/metrics_integration_test
rickie 1d77a3a
Dont need this
rickie b5c51f5
Forgot these
rickie 13d84c3
Drop file
rickie 4c2363c
Improve init patch
rickie fd5ebbc
Merge branch 'master' into rossendrijver/metrics_integration_test
rickie 6697858
Try to test the IT setup
rickie d7bf1a7
Test trigger?
rickie 9429021
Revert commit to test GHA
rickie eb43a77
Try to see if we can make it pass without
rickie 3d7a390
This works locally, well the test passes, but FileRule still seems ig…
rickie 6f5ae5b
This also doesnt work
rickie d25d84b
Merge remote-tracking branch 'origin/master' into rossendrijver/metri…
Stephan202 acf14a1
Sync
Stephan202 998ded9
Whitelist example.com:80
Stephan202 b31689f
Suggestions (WIP)
Stephan202 561275a
Suggestions (WIP)
Stephan202 e441bc3
Doh
Stephan202 331cea6
Suggestions (WIP)
Stephan202 18890ff
Suggestions (WIP)
Stephan202 1753ae9
Merge remote-tracking branch 'origin/master' into rossendrijver/metri…
Stephan202 10a84d0
Suggestions and improvements
rickie 296f9ee
Tweak
Stephan202 d27ae54
Run Checkstyle test again
Stephan202 b0046d3
Merge branch 'master' into rossendrijver/metrics_integration_test
rickie 3734ec6
Revert changes in `run-integration-tests`
rickie a6bd840
Polish
Stephan202 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to get unit tests to pass.