* Killing all mutants

PicnicSupermarket · Dec 12, 2023 · 3de47ce · 3de47ce
1 parent 8629f98
commit 3de47ce
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/...rone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/MonoZipOfMonoVoidUsage.java b/...rone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/MonoZipOfMonoVoidUsage.java
@@ -68,9 +68,7 @@ public final class MonoZipOfMonoVoidUsage extends BugChecker
           allOf(
               instanceMethod().onDescendantOf(MONO).named("zipWith"),
               toType(MethodInvocationTree.class, staticMethod().onClass(MONO).named("empty"))),
-          allOf(
-              onClassWithMethodName(MONO_VOID_TYPE, "zipWith"),
-              toType(MethodInvocationTree.class, hasGenericArgumentOfType(MONO))));
+          onClassWithMethodName(MONO_VOID_TYPE, "zipWith"));
 
   // On class Mono.zip, at least one element should match empty in order to proceed.
   private static final Matcher<ExpressionTree> STATIC_MONO_ZIP =
@@ -112,14 +110,6 @@ private static Matcher<ExpressionTree> onClassWithMethodName(
     };
   }
 
-  private static Matcher<MethodInvocationTree> hasGenericArgumentOfType(
-      Supplier<Type> genericDesiredType) {
-    return (tree, state) ->
-        tree.getArguments().stream()
-            .anyMatch(
-                arg -> isSameType(ASTHelpers.getType(arg), genericDesiredType.get(state), state));
-  }
-
   private static Matcher<MethodInvocationTree> hasGenericArgumentOfExactType(
       Supplier<Type> genericDesiredType) {
     return (tree, state) ->

diff --git a/...-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/MonoZipOfMonoVoidUsageTest.java b/...-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/MonoZipOfMonoVoidUsageTest.java
@@ -83,6 +83,10 @@ void replacementSuggestedFix() {
             "    Mono.zip(a, a);",
             "    a.zipWith(a);",
             "  }",
+            "",
+            "  public void m2() {",
+            "    Class clazz = getClass();",
+            "  }",
             "}")
         .addOutputLines(
             "A.java",
@@ -96,6 +100,10 @@ void replacementSuggestedFix() {
             "    Mono.zip(a, a);",
             "    a.zipWith(a);",
             "  }",
+            "",
+            "  public void m2() {",
+            "    Class clazz = getClass();",
+            "  }",
             "}")
         .doTest(BugCheckerRefactoringTestHelper.TestMode.TEXT_MATCH);
   }