Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to have error codes in the services #39

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

bgill92
Copy link
Collaborator

@bgill92 bgill92 commented Sep 20, 2023

Description

The service messages now have error codes.

Testing

In the docker container run

colcon build
colcon test

Make sure there are no test failures

@griswaldbrooks
Copy link
Collaborator

looks like you forgot to add the new messages

Copy link
Collaborator

@griswaldbrooks griswaldbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass

functional_programming_tests/include/pathing/pathing.hpp Outdated Show resolved Hide resolved
functional_programming_tests/src/pathing.cpp Outdated Show resolved Hide resolved
functional_programming_tests/src/pathing_manager.cpp Outdated Show resolved Hide resolved
functional_programming_tests/src/pathing_manager.cpp Outdated Show resolved Hide resolved
functional_programming_tests/src/pathing_manager.cpp Outdated Show resolved Hide resolved
functional_programming_tests/src/pathing_manager.cpp Outdated Show resolved Hide resolved
functional_programming_tests/src/pathing_manager.cpp Outdated Show resolved Hide resolved
functional_programming_tests/src/pathing_manager.cpp Outdated Show resolved Hide resolved
example_srvs/srv/GetPath.srv Outdated Show resolved Hide resolved
griswaldbrooks
griswaldbrooks previously approved these changes Oct 25, 2023
@griswaldbrooks griswaldbrooks merged commit fd551bd into ros2 Oct 25, 2023
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bgill92/update-service-message branch October 25, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants