Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update Maven Plugin Versions and add Apache Maven Wrapper #426

Closed
wants to merge 20 commits into from

Conversation

dariuszzbyrad
Copy link
Member

This PR introduces the Apache Maven Wrapper to the repository and updates the versions of Maven plugins to their latest stable releases.

Benefits:

  • Consistency: Ensures all developers and CI pipelines use the same Maven version.
  • Convenience: Simplifies setup for new developers, as Maven is automatically downloaded if unavailable locally.
  • Portability: Streamlines Maven usage across different operating systems (Windows, Linux, macOS).

Next steps:

  • Update all instructions and documentation pages to reflect the use of the Maven Wrapper instead of installing Maven locally.

FDelporte and others added 19 commits November 20, 2024 08:08
…().autoDetectMockPlugins().autoDetectPlatforms().build() usage when building Pi4j on a Pi
Build on pi requires Mock Providers be loaded for the test case execution
Refactor BoardInfoHelper and Improve Board Detection Mechanism
…javadocs

Add Javadoc comments and small refactor code
@FDelporte
Copy link
Member

Just an idea: wouldn't it be better to merge this into feature/#414 and keep this for the jump to Java 21?

@dariuszzbyrad dariuszzbyrad changed the base branch from develop to feature/#414 November 27, 2024 12:27
@dariuszzbyrad dariuszzbyrad changed the title Update Maven Plugin Versions and add Apache Maven Wrapper WIP: Update Maven Plugin Versions and add Apache Maven Wrapper Nov 27, 2024
@dariuszzbyrad
Copy link
Member Author

Just an idea: wouldn't it be better to merge this into feature/#414 and keep this for the jump to Java 21?

Ok, will do

@eitch
Copy link
Member

eitch commented Nov 27, 2024

To tell the truth i'm not particularly happy to commit binaries to the repo. I think the enforcement plugin is enough to force users to update their maven and have a local Maven properly configured.

@dariuszzbyrad
Copy link
Member Author

To tell the truth i'm not particularly happy to commit binaries to the repo. I think the enforcement plugin is enough to force users to update their maven and have a local Maven properly configured.

Yes, definitely! The idea is to include just three files:

The wrapper scripts (for Linux/MacOS and Windows)
The configuration file (maven-wrapper.properties)

This approach ensures simplicity while avoiding the need to commit binaries to the repository.

@dariuszzbyrad
Copy link
Member Author

For better readability, PR has been created as new one (#427)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants