Fix: NPE when directly launching an application #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on something else I noticed that it is no longer possible to directly launch an application by specifying it as the first argument, e.g. by running with the property
-Dcrowpi.launcher.args=BuzzerApp. Reason for that behavior is that directly calling an application will bypass therun()method, meaning that the context stored inpi4jdoes not get initialized and therefor causes a NullPointerException.This PR ensures that a context is always created, but also cleaned up properly after every execution. To avoid this from happening again, I've added a test case covering this scenario as well.