Resolve local includes #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using IDEs like Rider for developing shaders they often have problems with finding includes when included as virtual paths. See for example https://youtrack.jetbrains.com/issue/RIDER-69615 This can be often worked around when working with global shaders by using relative paths to virtual shader location. This cannot be done same way for code generated with HLSLMaterial. This change adds fallback mechanism when we find that include path isn't real virtual path. We try to check if this path is relative path to our hlsl file and if it is we try to find it in virtual mappings.
|
The change is sound, I'll try to merge it soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, me again 😄
I propose small improvement to includes parsing that allows working with paths that IDEs have less problems with.
When using IDEs like Rider for developing shaders they often have problems with finding includes when included as virtual paths.
See for example https://youtrack.jetbrains.com/issue/RIDER-69615
This can be often worked around when working with global shaders by using relative paths to virtual shader location.
This cannot be done same way for code generated with HLSLMaterial.
This change adds fallback mechanism when we find that include path isn't real virtual path.
We try to check if this path is relative path to our hlsl file and if it is we try to find it in virtual mappings.