Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build page, using JDK 14 #2173

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Zemogiter
Copy link
Contributor

Solves the #2115 so .deb package is working.
As for the optional step, I was unable to find a working link so I've removed it for now.

@Zemogiter Zemogiter requested a review from plata February 11, 2020 10:45
@madoar
Copy link
Collaborator

madoar commented Feb 12, 2020

@Zemogiter essentially you are saying that you need Java 13 to successfully run the build tool?

@madoar
Copy link
Collaborator

madoar commented Feb 12, 2020

I have two issues against this an update to Java 13:

  • Java 13 is not easily available on all distributions. Especially older ones may require custom package repositories
  • Java 13 is not a LTS version. This means that we would need to update the guide to Java 14 in around 2 months.

On another note it may be worth thinking about using Java 14 after it is released because it is planned to come with the new packaging tool, see also here.

@Zemogiter
Copy link
Contributor Author

@madoar yes I need java 13 to run the build tool and according to this:
https://en.wikipedia.org/wiki/Java_version_history
Java 14 won't be LTS either to it's kind of a moot point and 2 months isn't a short time.

@madoar
Copy link
Collaborator

madoar commented Feb 12, 2020

... according to this:
https://en.wikipedia.org/wiki/Java_version_history
Java 14 won't be LTS either to it's kind of a moot point and 2 months isn't a short time.

Yes, you are right about that. I mainly wanted to say that Java 14 comes brings additional benefits to Phoenicis (i.e. the final release of the packaging tool), which could be worth it to think about using Java 14 at least for building the installer packages.

@Zemogiter Zemogiter changed the title Update build page, using JDK 13 Update build page, using JDK 14 May 9, 2020
@plata
Copy link
Collaborator

plata commented May 10, 2020

@qparis should take a look at the packaging with Java 14.

@plata
Copy link
Collaborator

plata commented Jun 3, 2023

We should update this to Java 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants