Replace Nashorn with GraalVM #1857

plata · 2019-02-23T12:50:04Z

No description provided.

plata · 2019-03-04T15:49:44Z

@madoar I don't know how to replace the ScriptObjectMirror by Value while still using our InteractiveScriptSession functional interface. Do you have an idea?

madoar · 2019-03-04T15:58:26Z

Can you give me an example where you face the problems?

plata · 2019-03-04T16:15:48Z

E.g. in ShortcutRunner.

madoar · 2019-03-04T16:53:57Z

My IntelliJ doesn't seem to be able to find the polyglot package (for import org.graalvm.polyglot.Value;).
Do you have an idea?

madoar · 2019-03-04T16:57:09Z

With the import working it should be working with:

    public void run(ShortcutDTO shortcutDTO, List<String> arguments, Consumer<Exception> errorCallback) {
        final InteractiveScriptSession interactiveScriptSession = scriptInterpreter.createInteractiveSession();

        interactiveScriptSession.eval("include([\"engines\", \"wine\", \"shortcuts\", \"reader\"]);",
                ignored -> interactiveScriptSession.eval("new ShortcutReader()", output -> {
                    final Value shortcutReader = (Value) output;

                    shortcutReader.invokeMember("of", shortcutDTO);
                    shortcutReader.invokeMember("run", arguments);
                }, errorCallback), errorCallback);
    }

plata · 2019-03-05T07:45:37Z

I had tried this before already but I got: PolyglotMap cannot be cast to PolyglotValue. I think you only get Value if you use Context.

madoar · 2019-03-05T09:52:47Z

After pulling the newest changes from upstream I got my branch working and did some tests.
You're right I stumbled across the same error like you (the one with PolyglotMap and Value).

After debugging the code a little I identified the location of the problem. The problem is caused by the "cast" in: https://github.com/graalvm/graaljs/blob/0385428b1c2f2cc4212a85612435c2ea0f105488/graal-js/src/com.oracle.truffle.js.scriptengine/src/com/oracle/truffle/js/scriptengine/GraalJSScriptEngine.java#L205

As far as I found out polyglotContext.eval(source) returns a Value object, which is the then converted to a PolyglotMap object by the .as(Object.class) call.

I think that the best solution is to change our graal ScriptInterpreter to use a graal Context instead of a ScriptEngine.

plata · 2019-03-05T10:03:30Z

I've also tried that and got "Java is not defined". If you want to have a look, I can make a pr with my current state.

- make PhoenicisScriptEngine an interface - cleanup ShortcutRunner - add some comments - change the constructor argument of the JSAScriptEngine class

plata · 2019-03-05T13:43:52Z

Currently, I get

TypeError: INVOKE on JavaObject[com.oracle.truffle.js.javaadapters.org.phoenicis.engines.Engine@4c66c7 (com.oracle.truffle.js.javaadapters.org.phoenicis.engines.Engine)] failed due to: java.lang.ClassCastException: Cannot convert '(0) []'(language: JavaScript, type: Array) to Java type 'java.lang.String': Unsupported target type.

during an installation.

madoar · 2019-03-05T13:47:45Z

Does this occur when "casting" the Value to Installer or when accessing one of its methods?
Which application are you executing?

plata · 2019-03-05T13:51:26Z

Notepad++. The installation starts just fine and installs the correct Wine version but then it crashes. I'm assuming that it happens in Wine#run() but no idea how I could debug this.

plata · 2019-03-05T13:59:00Z

I can confirm my Wine#run() theory.

madoar · 2019-03-05T14:00:45Z

I just got:

Exception in thread "pool-3-thread-3" java.lang.ClassCastException: class org.graalvm.polyglot.Value cannot be cast to class java.util.Map (org.graalvm.polyglot.Value is in module org.graalvm.sdk of loader 'app'; java.util.Map is in module java.base of loader 'bootstrap')
	at [email protected]/org.phoenicis.engines.EngineSettingsManager.lambda$fetchAvailableEngineSettings$1(EngineSettingsManager.java:75)
	at [email protected]/org.phoenicis.scripts.engine.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:34)
	at [email protected]/org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:43)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

when removing an installed application and container

plata · 2019-03-05T14:04:03Z

EngineSettingsManager l.75. Not quite sure how to handle this.

madoar · 2019-03-05T14:24:17Z

About your previous problem:
I have no clue, where exactly the problem is located. The error message indicates that a javascript array is passed to the Java method where a String is required.

The problem for me is that the responsible script code for this stuff spans 3+ files, which include both the engine "implementation" and "object" code. After following two or three invocations I don't know anymore if the run invocation now targets the "implementation" object, the "object" object or maybe even the Java interface?

plata · 2019-03-05T16:14:44Z

I added some debug output but everything looked ok. The call hierarchy is not that difficult really: InstallerScript → Wine(Object)#run → Java Engine interface → Wine(Implementation)#run. The problem occurs when the Java interface is called from Wine(Object)#run because this is the place where we go from Javascript to Java.

plata · 2019-03-05T16:29:02Z

I found it. It's a bug in scripts. I will create a PR.

madoar · 2019-06-05T20:13:43Z

Ok, I've experimented a bit. I can reproduce the exception(s). Interestingly they only seem to occur when executing Phoenicis from the IDE. If I install it via a built deb archive I don't get the error message and the application starts like it should.

I believe the reason for the exception is a missing parameter which needs to be passed to the JVM. Somehow we set this parameter/option correctly inside the deb installer but at least I don't do that inside the IDE.

plata · 2019-06-06T18:01:06Z

That's an interesting find. Nevertheless, I think it's something which should be fixed before we can merge this.

madoar · 2019-06-09T10:00:59Z

I've searched some more but still can't find the reason for the error messages. The only think I found out is that the errors are thrown when parsing a javascript regex. For example an exception is thrown for the lines:

phoenicis/phoenicis-scripts/src/main/resources/org/phoenicis/scripts/nashorn/builtins/utils.js

Lines 26 to 27 in 2ee4666

 }); 

 };

I can't find any significant differences between my IntelliJ setup and the options the installer script sets.

qparis · 2019-06-09T15:07:39Z

If you replace ALL_MODULE_PATH with jdk.crypto.ec,java.base,javafx.base,javafx.web,javafx.media,javafx.graphics,javafx.controls,java.naming,java.sql,java.scripting,jdk.scripting.nashorn,jdk.internal.vm.ci,jdk.internal.vm.compiler,org.graalvm.truffle,java.desktop,java.prefs,java.xml

it should work

madoar

I can confirm replacing ALL_MODULE_PATH with jdk.crypto.ec,java.base,javafx.base,javafx.web,javafx.media,javafx.graphics,javafx.controls,java.naming,java.sql,java.scripting,jdk.scripting.nashorn,jdk.internal.vm.ci,jdk.internal.vm.compiler,org.graalvm.truffle,java.desktop,java.prefs,java.xml solves the problem.

@qparis do you know how the two settings differ? I mean I thought that ALL_MODULE_PATH would auto-add all modules located on the module path?

qparis · 2019-06-09T15:19:04Z

Actually java.desktop,java.prefs,java.xml are not needed

@madoar Seems that some module are not detected automatically with ALL-MODULE-PATH

qparis · 2019-06-09T15:44:20Z

@plata Feel free to merge whenever you think we are stable enough.
Next step is to get rid of nashorn compatibility

plata · 2019-06-09T18:27:43Z

Do we need to update the IntelliJ IDEA documentation and and the flatpak? If so, what's the final list of required modules?

qparis · 2019-06-09T20:32:45Z

The list of package is the same than than in the packaging script.
I have no idea concerning flatpak. Do you pass the module list somewhere?

qparis · 2019-06-10T09:00:59Z

@plata Can this be merged?

plata · 2019-06-10T09:18:54Z

I'm doing a quick test then I will merge, yes.

qparis · 2019-06-10T09:27:19Z

Does it mean that it will not compile on Ubuntu?

plata · 2019-06-10T09:34:31Z

This is just for the IntelliJ IDEA documentation. Phoenicis itself is compiled with Java 11 already since b1b1ad5.

qparis · 2019-06-10T09:36:09Z

Ok

plata · 2019-06-10T09:36:55Z

Apart from that: @madoar is using Ubuntu or Linux Mint so we should be fine.

plata and others added 2 commits January 30, 2019 17:20

First steps (#1637)

567752f

Merge branch 'master' into graalvm

8dce77f

plata added the Do not merge! label Feb 23, 2019

plata and others added 4 commits February 23, 2019 13:51

ShortcutRunner: include by ID

c098fd2

Merge branch 'master' into graalvm

5693b51

Rename Nashorn related classes to "PhoenicisScript..." (#1870)

d0ec44a

Allow to create graal.js engine in PhoenicisScriptEngineFactory (#1872)

4f9422f

madoar and others added 4 commits March 5, 2019 13:03

Add phoenicis script engine interface (#1882)

1eeb9d7

- make PhoenicisScriptEngine an interface - cleanup ShortcutRunner - add some comments - change the constructor argument of the JSAScriptEngine class

Remove ScriptObjectMirror (#1883)

7f612a7

Fix usage of Java interfaces (#1884)

14def23

Merge branch 'master' into graalvm

12a80ff

madoar and others added 2 commits March 5, 2019 17:47

Add interface communication approach to documentation (#1885)

9e5b26d

Fix retrieval of engine settings (#1886)

52a81f3

madoar mentioned this pull request Jun 5, 2019

Add a new "Change engine version" button to the ContainerOverviewPanel #1970

Merged

Quentin PARIS added 4 commits June 9, 2019 17:08

Merge remote-tracking branch 'upstream/graalvm' into graalvm

dd6da65

Fixed dependencies

bd28b7f

Java12 packaging

6384354

Merging

36c4ce1

qparis approved these changes Jun 9, 2019

View reviewed changes

Java12 packaging - Disclaimer

f05d890

madoar approved these changes Jun 9, 2019

View reviewed changes

Jpackager: Java 12+

087179e

Quentin PARIS added 2 commits June 9, 2019 23:27

Jpackager: Memory switch

2fd6be1

Fixed module path

47be5f2

plata added 2 commits June 10, 2019 11:18

Remove classpath parameter

aa3fb2a

Merge branch 'master' into graalvm

c9598be

Remove Java 10 support

f6073e6

plata merged commit 240e682 into master Jun 10, 2019

plata deleted the graalvm branch June 10, 2019 09:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Nashorn with GraalVM #1857

Replace Nashorn with GraalVM #1857

plata commented Feb 23, 2019 •

edited

Loading

plata commented Mar 4, 2019

madoar commented Mar 4, 2019

plata commented Mar 4, 2019

madoar commented Mar 4, 2019

madoar commented Mar 4, 2019

plata commented Mar 5, 2019

madoar commented Mar 5, 2019

plata commented Mar 5, 2019 •

edited

Loading

plata commented Mar 5, 2019

madoar commented Mar 5, 2019

plata commented Mar 5, 2019 •

edited

Loading

plata commented Mar 5, 2019

madoar commented Mar 5, 2019

plata commented Mar 5, 2019

madoar commented Mar 5, 2019 •

edited

Loading

plata commented Mar 5, 2019

plata commented Mar 5, 2019

madoar commented Jun 5, 2019

plata commented Jun 6, 2019

madoar commented Jun 9, 2019

qparis commented Jun 9, 2019

madoar left a comment

qparis commented Jun 9, 2019

qparis commented Jun 9, 2019

plata commented Jun 9, 2019

qparis commented Jun 9, 2019

qparis commented Jun 10, 2019

plata commented Jun 10, 2019

qparis commented Jun 10, 2019

plata commented Jun 10, 2019

qparis commented Jun 10, 2019

plata commented Jun 10, 2019

Replace Nashorn with GraalVM #1857

Replace Nashorn with GraalVM #1857

Conversation

plata commented Feb 23, 2019 • edited Loading

plata commented Mar 4, 2019

madoar commented Mar 4, 2019

plata commented Mar 4, 2019

madoar commented Mar 4, 2019

madoar commented Mar 4, 2019

plata commented Mar 5, 2019

madoar commented Mar 5, 2019

plata commented Mar 5, 2019 • edited Loading

plata commented Mar 5, 2019

madoar commented Mar 5, 2019

plata commented Mar 5, 2019 • edited Loading

plata commented Mar 5, 2019

madoar commented Mar 5, 2019

plata commented Mar 5, 2019

madoar commented Mar 5, 2019 • edited Loading

plata commented Mar 5, 2019

plata commented Mar 5, 2019

madoar commented Jun 5, 2019

plata commented Jun 6, 2019

madoar commented Jun 9, 2019

qparis commented Jun 9, 2019

madoar left a comment

Choose a reason for hiding this comment

qparis commented Jun 9, 2019

qparis commented Jun 9, 2019

plata commented Jun 9, 2019

qparis commented Jun 9, 2019

qparis commented Jun 10, 2019

plata commented Jun 10, 2019

qparis commented Jun 10, 2019

plata commented Jun 10, 2019

qparis commented Jun 10, 2019

plata commented Jun 10, 2019

plata commented Feb 23, 2019 •

edited

Loading

plata commented Mar 5, 2019 •

edited

Loading

plata commented Mar 5, 2019 •

edited

Loading

madoar commented Mar 5, 2019 •

edited

Loading