Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grid): L3-4300 - grid update #477

Merged
merged 4 commits into from
Jan 17, 2025
Merged

feat(grid): L3-4300 - grid update #477

merged 4 commits into from
Jan 17, 2025

Conversation

davidicus
Copy link
Collaborator

@davidicus davidicus commented Jan 17, 2025

Jira ticket

L3-4300

Screenshots

Before After
image image

https://www.figma.com/deck/hqJJvOsa9XrlafXAR9aiwS/EASEL-Foundation?node-id=42-2&viewport=-21477%2C-154%2C0.71&t=obFPxmoyoH7LUaAw-1&scaling=min-zoom&content-scaling=fixed&page-id=0%3A1

Summary

Added an xxxl spacing token and fixed some stories.

Change List (describe the changes made to the files)

  • Changed gridMargins mixin to use the new spacing xxxl token in src/scss/_utils.scss
  • Added spacing token to variable in src/scss/_vars.scss
  • Updated the design spec for spacing tokens in src/design/spacing-tokens/spacing-tokens.mdx

Acceptance Test (how to verify the PR)

  • Grid story should only have 10 columns in story at large breakpoint and above.

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit c1230f9
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/678aa81888cb31000808cb83
😎 Deploy Preview https://deploy-preview-477--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidicus davidicus merged commit a99f354 into main Jan 17, 2025
13 checks passed
@davidicus davidicus deleted the L3-4300-rail-grid branch January 17, 2025 19:08
davidicus pushed a commit that referenced this pull request Jan 17, 2025
# [1.108.0](v1.107.0...v1.108.0) (2025-01-17)

### Features

* **grid:** L3-4300 - grid update ([#477](#477)) ([a99f354](a99f354))
@davidicus
Copy link
Collaborator Author

🎉 This issue has been resolved in version 1.108.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants