Feature/L3-410 Chinese translations fixes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinelliottcobb
requested review from
davidicus and
adietrich3074
as code owners
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
This looks great. Will we be updating this file for all features and bug fixes going forward?
| @@ -56,6 +60,9 @@ export const i18n = { | |||
| viewingDatesLabel: '_viewingDatesLabel_', | |||
| viewingHours1Label: '_viewingHours1Label_', | |||
| viewingHours2Label: '_viewingHours2Label_', | |||
| emailLabel: '_emailLabel_', | |||
There was a problem hiding this comment.
For these i18n constants what is the purpose of the leading and trailing underscores?
There was a problem hiding this comment.
To differentiate between the normal text and a "translated" text.
adietrich3074
approved these changes
Mar 12, 2024
davidicus
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #L3-410
Summary
Change List (describe the changes made to the files)
emaiLabelemailLinkLabelemailToggleLabelpreviewToggleLabelAcceptance Test (how to verify the PR)
previewToggleLabelshould read "Additional Hours"Things to look for during review
phillipsclass prefix is using the prefix variabledata-testidattribute.