Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated error styling for input component #45

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

adietrich3074
Copy link
Collaborator

Summary

Simple update to error styling for inputs

Change List (describe the changes made to the files)

  • Colored border and inset box-shadow applied to input field
  • Removal of color applied to input label when in error state
  • Addition of error-pink color variable

Acceptance Test (how to verify the PR)

View input component with invalid property set to true

Regression Test (how to make sure this PR doesn't break old functionality)

Only styling is affected. Will have no effect on the functionality of the input.

Things to look for during review

  • Make sure all references to phillips class prefix is using the prefix variable
  • All major areas have a data-testid attribute.
  • All strings should be translatable.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue
  • Make sure all commits messages follow convention and are appropriate for the changes

Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit a294852
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/65c671f6b4440b00083ba4bb
😎 Deploy Preview https://deploy-preview-45--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidicus davidicus merged commit b66ca0f into main Feb 12, 2024
8 checks passed
@davidicus davidicus deleted the input-error-styling branch February 12, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants