-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bidsnapshot): L3-4378 if i have bid on a lot but lost it should say won for #443
Conversation
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This seems to contradict the compendium for ObjectTile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there somewhere else that has this documented?
## [1.98.1](v1.98.0...v1.98.1) (2024-12-03) ### Bug Fixes * **bidsnapshot:** L3-4378 if i have bid on a lot but lost it should say won for ([#443](#443)) ([a6145dc](a6145dc))
🎉 This issue has been resolved in version 1.98.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Jira ticket
Jira Ticket ID
Screenshots
Summary
BidSnapshot was showing sold for instead of won for when the user lost the bid, I also refactored the code for BidSnapshot to make it more understandable
Change List (describe the changes made to the files)
<Detail
linesAcceptance Test (how to verify the PR)
Sold for
and the sold for price. Switch thebidStatus
to all of the statuses, you should seeWon for
. Now remove thesoldPrice
and you should not see the soldPrice line at all, but if the user has bid and won (bidStatus
) you should still see the won/lost messageRegression Test
Evidence of testing
Things to look for during review
feat(scope): ...
if aminor
release should be triggered.phillips
class prefix are using the prefix variabledata-testid
attribute.New Components
index.ts
filecomponentStyles.scss
file.