Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bidsnapshot): L3-4378 if i have bid on a lot but lost it should say won for #443

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

scottdickerson
Copy link
Contributor

Jira ticket

Jira Ticket ID

Screenshots

Before After
image image

Summary

BidSnapshot was showing sold for instead of won for when the user lost the bid, I also refactored the code for BidSnapshot to make it more understandable

Change List (describe the changes made to the files)

  • change(BidSnapshot): soldprice label uses wonForText if the user has ever bid. Split the inner Detail determinations to separated <Detail lines

Acceptance Test (how to verify the PR)

  • Go to the BidSnapshot story, switch the AuctionStatus to Past. You should see Sold for and the sold for price. Switch the bidStatus to all of the statuses, you should see Won for. Now remove the soldPrice and you should not see the soldPrice line at all, but if the user has bid and won (bidStatus) you should still see the won/lost message

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 2660ed1
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/674e07a2d5c55e00088885aa
😎 Deploy Preview https://deploy-preview-443--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidicus
Copy link
Collaborator

This seems to contradict the compendium for ObjectTile

@scottdickerson scottdickerson merged commit a6145dc into main Dec 3, 2024
12 checks passed
@scottdickerson scottdickerson deleted the L3-4378-lot-status branch December 3, 2024 14:49
Copy link
Collaborator

@davidicus davidicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there somewhere else that has this documented?

davidicus pushed a commit that referenced this pull request Dec 3, 2024
## [1.98.1](v1.98.0...v1.98.1) (2024-12-03)

### Bug Fixes

* **bidsnapshot:** L3-4378 if i have bid on a lot but lost it should say won for ([#443](#443)) ([a6145dc](a6145dc))
@davidicus
Copy link
Collaborator

🎉 This issue has been resolved in version 1.98.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants