Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(footer): L3-4461 Update casing on news subscription link #439

Closed

Conversation

SRangineni88
Copy link
Contributor

@SRangineni88 SRangineni88 commented Nov 27, 2024

Jira ticket

L3-4461

Screenshots

Before After
image image

Summary

Update title case this so it says Subscribe To Our Newsletter

Open Screenshot 2024-11-04 at 11.17.21 AM.png
Screenshot 2024-11-04 at 11.17.21 AM.png

Change List (describe the changes made to the files)

  • Additions, Changes, and Removals

Acceptance Test (how to verify the PR)

  • Add step by step instructions on how to verify the change

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for phillips-seldon failed.

Name Link
🔨 Latest commit 2fe8cae
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/674730e14623ba00088f86aa

@SRangineni88 SRangineni88 deleted the fix/L3-4461-Update-Newsletter-Sign-Up-to-Title-Case branch November 27, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant