Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lotdetails): L3-3149 tweaks to Video and Carousel to support obj… #420

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

sgrund14
Copy link
Contributor

@sgrund14 sgrund14 commented Nov 11, 2024

…ect video

Jira ticket

L3-3149

Summary

Small tweaks to carousel and video to support the object video on lots

Change List (describe the changes made to the files)

  • Video: don't default aspect ratio to anything (sometimes we might not want to use it)
  • Video: accept props for a ref on the iframe and a custom classname
  • Carousel: trigger on slide changed using the onSlidesInView event, which happens faster than the onSettled event. better for autoplaying the video

Acceptance Test (how to verify the PR)

  • Add step by step instructions on how to verify the change

Regression Test

  • (Optional) Add verification steps to make sure this PR doesn't break old functionality

Evidence of testing

  • Post logs, screenshots, etc

Things to look for during review

  • PR title should correctly describe the most significant type of commit. I.e. feat(scope): ... if a minor release should be triggered.
  • All commit messages follow convention and are appropriate for the changes
  • All references to phillips class prefix are using the prefix variable
  • All major areas have a data-testid attribute.
  • Document all props with jsdoc comments
  • All strings should be translatable.
  • Unit tests should be written and should have a coverage of 90% or higher in all areas.

New Components

  • Are there any accessibility considerations that need to be taken into account and tested?
  • Default story called "Playground" should be created for all new components
  • Create a jsdoc comment that has an Overview section and a link to the Figma design for the component
  • Export the component and its typescript type from the index.ts file
  • Import the component scss file into the componentStyles.scss file.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 57fd02b
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/67325a0b035937000872e4ea
😎 Deploy Preview https://deploy-preview-420--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@scottdickerson scottdickerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottdickerson scottdickerson merged commit 7c302db into main Nov 13, 2024
14 checks passed
@scottdickerson scottdickerson deleted the L3-3149 branch November 13, 2024 19:06
davidicus pushed a commit that referenced this pull request Nov 13, 2024
# [1.90.0](v1.89.1...v1.90.0) (2024-11-13)

### Features

* **lotdetails:** L3-3149 tweaks to Video and Carousel to support obj… ([#420](#420)) ([7c302db](7c302db))
@davidicus
Copy link
Collaborator

🎉 This issue has been resolved in version 1.90.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants