Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: still troublshooting build #42

Merged
merged 1 commit into from
Jan 21, 2024
Merged

fix: still troublshooting build #42

merged 1 commit into from
Jan 21, 2024

Conversation

davidicus
Copy link
Collaborator

Closes #

Summary

  • Troubleshooting issues stemming from classnames being a commonjs modulle.

Change List (describe the changes made to the files)

  • change build output to mjs. Make changes to references in package.json
  • update vite.config.ts to outpput mjs files

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to phillips class prefix is using the prefix variable
  • All major areas have a data-testid attribute.
  • All strings should be translatable.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue
  • Make sure all commits messages follow convention and are appropriate for the changes

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit 486dfc7
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/65ad9019ae62af0009805c97
😎 Deploy Preview https://deploy-preview-42--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidicus davidicus merged commit 481a49d into main Jan 21, 2024
8 checks passed
@davidicus davidicus deleted the build-tweak branch January 21, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant