Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-8792 - Implementation of ViewingCard and its various child components #36

Merged
merged 16 commits into from
Nov 6, 2023

Conversation

davidicus
Copy link
Collaborator

Closes # WEB-8792

Summary

  • This PR brings in a number of new components for Viewings and the cards needed in the CMS. There is also additional changes made to existing components that needed updates to address needs in ViewingCards.

Change List (describe the changes made to the files)

  • Changed button to support ghost button and updated stories.
  • Changed Header component is it was referencing the buttons old prop type
  • Changed case of noOP to noOp in utils file and updated places where it was used. (DateTimePicker)
  • Added 'name' attribute to inputs and added more styles for when input is hidden to hide label as well
  • Added focus state for toggle input
  • Created a "stateful" viewings list component (StatefulViewingsList) as a way to run stories and test but could probably export to use in apps
  • Created ViewingsList, ViewingsList.stories, ViewingsList.test, and _viewingsList.scss files
  • Created ViewingsListCard and ViewingsLIstCard.stories file
  • Created ViewingsListCardForm file
  • Created a Viewings list utils file to help demo and test stories.
  • Updated main export index file to include ViewingsList component.
  • Some tweaks to our style partials
  • Tweaked the vite config file to address bug I was seeing with the SVGs imports.

Acceptance Test (how to verify the PR)

  • Go through stories for ViewingsCards and ViewingList.
  • Go through Button and Input stories to be sure they still work as expected.

Regression Test (how to make sure this PR doesn't break old functionality)

  • Make sure Button and Input fields still work as expected. This should be fairly quick glance as they have not been used yet.

Things to look for during review

  • Make sure all references to phillips class prefix is using the prefix variable
  • All major areas have a data-testid attribute.
  • All strings should be translatable.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue
  • Make sure all commits messages follow convention and are appropriate for the changes

Copy link

netlify bot commented Nov 3, 2023

Deploy Preview for phillips-seldon ready!

Name Link
🔨 Latest commit aef1dee
🔍 Latest deploy log https://app.netlify.com/sites/phillips-seldon/deploys/654901e61831b10008d18144
😎 Deploy Preview https://deploy-preview-36--phillips-seldon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

font-size: 1.25rem;
}

&-form__preview-set {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to nest __preview-set under -form?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but we currently dont have any styles for the -form element alone.

@davidicus davidicus merged commit 2de4c1e into main Nov 6, 2023
7 checks passed
@scottdickerson scottdickerson deleted the viewings-card branch May 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants