-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB-8792 - Implementation of ViewingCard and its various child components #36
Conversation
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
font-size: 1.25rem; | ||
} | ||
|
||
&-form__preview-set { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to nest __preview-set under -form?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but we currently dont have any styles for the -form
element alone.
Closes # WEB-8792
Summary
Change List (describe the changes made to the files)
noOP
tonoOp
in utils file and updated places where it was used. (DateTimePicker)StatefulViewingsList
) as a way to run stories and test but could probably export to use in appsViewingsList
,ViewingsList.stories
,ViewingsList.test
, and_viewingsList.scss
filesViewingsListCard
andViewingsLIstCard.stories
fileViewingsListCardForm
fileutils
file to help demo and test stories.index
file to include ViewingsList component.Acceptance Test (how to verify the PR)
Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
phillips
class prefix is using the prefix variabledata-testid
attribute.