feat(header): L3-376 Added Header component #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e state across child components
# Conflicts: # src/components/Link/_link.scss
✅ Deploy Preview for phillips-seldon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/components/Navigation/NavigationItem/NavigationItem.stories.tsx
Outdated
Show resolved
Hide resolved
src/components/Navigation/NavigationItemTrigger/NavigationItemTrigger.tsx
Show resolved
Hide resolved
src/components/Navigation/NavigationItemTrigger/NavigationItemTrigger.tsx
Outdated
Show resolved
Hide resolved
| <button | ||
| type="button" | ||
| onClick={handleMenuToggle} | ||
| className={classnames(`${px}-header__toggle-btn`, { |
There was a problem hiding this comment.
is an aria-label needed here? or will the span be picked up as the accessible name of this button?
Do we need aria-expanded and aria-controls here?
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-expanded
There was a problem hiding this comment.
Yes, I believe we do. To that point do we need to pass in an id for the menu which this toggle controls?
adietrich3074
requested review from
justinelliottcobb and
constantinehuzenko
as code owners
…PhillipsAuctionHouse/seldon into feature/L3-376_Header_Component
…use spacing tokens
…PhillipsAuctionHouse/seldon into feature/L3-376_Header_Component
davidicus
pushed a commit
that referenced
this pull request
Jul 8, 2024
# [1.27.0](v1.26.2...v1.27.0) (2024-07-08) ### Features * **header:** L3-376 Added Header component ([#168](#168)) ([7e196c5](7e196c5))
|
🎉 This issue has been resolved in version 1.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
L3-376
Screenshots
DESKTOP
MOBILE
Summary
This PR is for the addition of the Header component to the seldon repo. The following components have been added in this PR:
Acceptance Test (how to verify the PR)
Things to look for during review
feat(scope): ...if aminorrelease should be triggered.phillipsclass prefix are using the prefix variabledata-testidattribute.New Components
index.tsfile