Fields modifications including trait statistics graphs #985
+9,456
−4,287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/src/main/java/com/fieldbook/tracker/dialogs/NewTraitDialog.kt # app/src/main/java/com/fieldbook/tracker/offbeat/traits/formats/Formats.kt # app/src/main/java/com/fieldbook/tracker/offbeat/traits/formats/parameters/CameraTypes.kt
# Conflicts: # app/src/main/java/com/fieldbook/tracker/dialogs/NewTraitDialog.kt # app/src/main/java/com/fieldbook/tracker/offbeat/traits/formats/parameters/CameraTypes.kt
# Conflicts: # app/src/main/java/com/fieldbook/tracker/dialogs/NewTraitDialog.kt # app/src/main/java/com/fieldbook/tracker/offbeat/traits/formats/parameters/CameraTypes.kt
…e view now just loads 512x512 thumbnails
added gopro hardware capture
fit gopro preview to screen
…of images, necessary for raw/large images that exceed phone memory
Added system, preview, and resolution settings to photo trait layout. Photo trait now optionally uses camerax when in non-system mode, which allows a preview and target resolution selection (target is not guaranteed)
# Conflicts: # app/src/main/java/com/fieldbook/tracker/offbeat/traits/formats/contracts/UsbCameraFormat.kt
Added preview, auto white balance and auto focus checkboxes.
They're sorted the same way as in the collect and traits activity. I'm thinking that's probably the expected order. |
|
Changes based on external review:
|
|
For charts it would be difficult to add axis labels, they are not supported natively in MPAndroidChart and the workarounds with custom textviews are pretty messy. I don't think it's worth it to add more elements to the already complex data card, only case I can think of where the axis meanings could initially be confusing with the existing labels (a trait with numbered categories and little data collected) should be pretty rare. Still working on the chip change per our discussion in slack |
This reverts commit 1e69984.
…o fields_modifications # Conflicts: # app/src/main/java/com/fieldbook/tracker/activities/CollectActivity.java # app/src/main/java/com/fieldbook/tracker/dialogs/NewTraitDialog.kt # app/src/main/java/com/fieldbook/tracker/offbeat/traits/formats/contracts/GoProFormat.kt # app/src/main/java/com/fieldbook/tracker/offbeat/traits/formats/contracts/PhotoFormat.kt # app/src/main/java/com/fieldbook/tracker/traits/LabelPrintTraitLayout.java # app/src/main/java/com/fieldbook/tracker/traits/PhotoTraitLayout.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a summary of your changes including motivation and context.
If these changes fix a bug or resolves a feature request, be sure to link to that issue.
Closes #178
Closes #968
Closes #960
Closes #52
Type of change
What type of changes does your code introduce? Put an
xin boxes that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Checklist:
Changelog entry
Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.