Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field specific traits #1036

Draft
wants to merge 73 commits into
base: main
Choose a base branch
from
Draft

Field specific traits #1036

wants to merge 73 commits into from

Conversation

bellerbrock
Copy link
Collaborator

Description

Provide a summary of your changes including motivation and context.
If these changes fix a bug or resolves a feature request, be sure to link to that issue.

Adds trait editor activity access from field detail page, with any visibility changes tracked on the field-level using a study_id jsonb column in the observation_variables table.

closes #1014

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

Changelog entry

Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.


@bellerbrock bellerbrock marked this pull request as draft August 27, 2024 16:36
@bellerbrock
Copy link
Collaborator Author

Not a finished product yet, opening as a draft PR as a place for testing/feedback

The main remaining question is if trait visibility should be field-specific everywhere now, or just when accessing the trait and collect activities from the field detail fragment? So far the changes are implemented with the second strategy in mind - preservsing the field-independent visibility info when accessing the trait and collect activities from the config activity. But I'm worried that both approaches side-by-side will be confusing, and it would be a lot simpler to completely switch over.

If we don't completely switch over I will still need to go through and update additional places that check trait visibility (summary, datagrid, export) to determine in which contexts they should apply the field-specific trait visibility or the general trait visibility.

I also still need to set field-specific visibility for traits imported by Brapi sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST]: Maintain Obs Vars list associated with DeltaBreed experimental dataset
2 participants