-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[add] modelExporters #8
Conversation
…v" dependencies were not installed - cleanup
TODO:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
+ Coverage 92.20% 93.22% +1.01%
==========================================
Files 12 14 +2
Lines 1181 1402 +221
==========================================
+ Hits 1089 1307 +218
- Misses 92 95 +3
☔ View full report in Codecov by Sentry. |
…ation, so that Calculators can be passed without any adjustments like into others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if the calculator is empty it is not an error?
Based on the current PR state, it does raise an AssertionError with the message 'No models loaded in calculator. Nothing to export.' I will add tests to verify these errors occur as intended. |
…ted feature vector
I added the aforementioned tests and documentation page on why-and-how to use Exporters. |
…ed without dev dependencies
…esthetic adjustment
modelExporters
module with 3 Exporter classes, allowing conversion and saving of the loaded models (including ones modified within pySIPFENN transfer learning runs) into ONNX, PyTorch, and CoreML formats.ONNXExporter
also allows for model conversion to FP16 precision, lowering the size by a factor of 2, as well as model simplification with the ONNX optimizer toolset.