Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V 5 #4

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

V 5 #4

wants to merge 12 commits into from

Conversation

ricardonpa
Copy link
Collaborator

Hi @amkrajewski ,

Please check the new modifications to ULTERA-contribute:

  • Added new ULTERA manual (Contributor's Guide)
  • Simplified README by moving excess content to the manual
  • Added csv2README to automatically update the README if csv files exist
  • Added new action to notifying new contributions*
  • This last modification was implemented in replacement of automatically notifying the ULTERA-maintainers team/ opening a PR to merge new contributions committed to fork repositories. Unfortunately I couldn't make any of these two approaches to work entirely because of permission issues. This way the user is instructed to notify about new contributions by creating a new issue here at ULTERA-contribute, which conversely notify the ULTERA-maintainers team to run the ingestion pipeline.

@amkrajewski
Copy link
Contributor

Hi @ricardonpa, great work! I have a bunch of comments to discuss and modify some things before we can merge, considering some indirect implications like backward compatibility, but it, again, looks great :)

Some quick notes for future direction:

  • We probably want to have an action that will generate the manual based on the ULTERA repo once we make that one public. Some tables and text should be live updated based on the database content and rulesets.

  • Template V5 may break the upload scheme for collections assigned "parent database", which expects the "Parent Database" name in place of the "Direct Fetch" marker (automatically set to False), which seems to be removed.

  • The automatic PR feature, as you noted, won't work because of the permissions. What we want is either (a) bot looking for mentions (akin to JOSS) with write to ULTERA-push, or (b) a CRON job Action within ULTERA-push checking linked submodules for updates once a day and opening PRs to be approved (akin to arXiv). I'm leaning towards the latter as it is still elegant but has fewer moving parts to break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants