FIX: fix dataplot for ternary cases with __HYPERPLANE__ #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of __HYPERPLANE__ in datasets was causing the dimensionality of tie-regions to be artificially increased. For example, a 3 phase region with an additional __HYPERPLANE__ overall composition was being categorized as a 4 phase region and not plotted.
bocklund
force-pushed
the
FIX-ternary-dataplot-ravel-hyperplane
branch
from
87ada86 to
31462f5
Compare
|
Added some tests with the expected output (with the The guiding principle is that we can plot tie-lines (or tie-triangles) when all of the phase compositions are known. Currently for ternary tie-triangles we don't directly plot phase compositions, just tie-triangles, and so nothing gets plotted unless all three phase compositions are present ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of
__HYPERPLANE__overall compositions in datasets was causing the dimensionality of tie-regions to be artificially increased. For example, a 3 phase region with an additional HYPERPLANE overall composition was being categorized as a 4 phase region and not plotted. This did not affect binary dataplotting because we did not differently depending on the number of phases in tie-regions (in ternary dataplotting we draw three phase regions as red tie-triangles).