Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial/mean point to chains to fix #243 #249

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

toastedcrumpets
Copy link
Contributor

I've attempted to patch issue #243. Running pytest before/after the patch I get the same number of errors, i.e.

collected 300 items

espei/analysis.py .                                                                                              [  0%]
espei/datasets.py .                                                                                              [  0%]
espei/espei_script.py .                                                                                          [  1%]
espei/plot.py ssss                                                                                               [  2%]
espei/priors.py ....                                                                                             [  3%]
espei/sublattice_tools.py ..                                                                                     [  4%]
espei/utils.py ....                                                                                              [  5%]
espei/parameter_selection/model_building.py .                                                                    [  6%]
espei/parameter_selection/redlich_kister.py .                                                                    [  6%]
tests/test_core_utils.py .....                                                                                   [  8%]
tests/test_database_utils.py ................................................................................... [ 35%]
................................................................................                                 [ 62%]
tests/test_datasets.py ............x.                                                                            [ 67%]
tests/test_error_functions.py ...............................                                                    [ 77%]
tests/test_mcmc.py ...xx....                                                                                     [ 80%]
tests/test_model_building.py ..........                                                                          [ 83%]
tests/test_optimizer.py .                                                                                        [ 84%]
tests/test_parameter_generation.py ....................                                                          [ 90%]
tests/test_parameter_generation_utils.py ....                                                                    [ 92%]
tests/test_plotting.py ....                                                                                      [ 93%]
tests/test_schema.py ..........                                                                                  [ 96%]
tests/test_utils.py ..........                                                                                   [100%]

Happy to have comments/reviews!

@bocklund
Copy link
Member

@toastedcrumpets Thanks for putting something together! It looks like there's just one failure introduced where we test that the parameter initialization is consistent and not changing. Since this code explicitly changes the parameter initialization, can you please update that test?

Otherwise looks great :)

@bocklund bocklund self-requested a review November 20, 2023 23:48
Copy link
Member

@bocklund bocklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a link to the function that needs to be updated:

def test_parameter_initialization():

@toastedcrumpets
Copy link
Contributor Author

Apologies @bocklund, I didn't see that test failure for some reason, but sure enough its there when I rerun pytest now. I've patched this if you want to try rerunning the checks?

Copy link
Member

@bocklund bocklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! :)

@bocklund bocklund merged commit d435b13 into PhasesResearchLab:master Nov 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants