Phat Contract 2.0 Compliance #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4x3rotab
reviewed
Dec 18, 2023
ink/crates/phat_rollup_anchor_ink/src/traits/js_rollup_anchor.rs
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| #[openbrush::trait_definition] | ||
| pub trait JsRollupAnchor: |
There was a problem hiding this comment.
How does it simplify the use of the JS-based rollup anchor? Could you give some exapmle?
There was a problem hiding this comment.
You can find an example here: https://github.com/GuiGou12358/decentralized_oracle-graph-api-oracle/blob/main/ink/contracts/graph_api_consumer/lib.rs#L215
The JsRollupAnchor trait implements the communication logic between the JS Phat contract and the ink! contract consumer.
It alows to reduce the complexity of the contrat consumer. The developer:
- doesn't have to test if the configured script/settings hashes match with the received ones. All is done in the
JsRollupAnchortrait. - can use directly the business struct without care to the struct JsResponse
Co-authored-by: h4x3rotab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the function pop_raw to get the value without decoding. This way the decoding can be done in the js code.
Add the trait js_rollup_anchor to ease the implementation of ink! smart contract