Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt tutorial for Dancer 2 #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adapt tutorial for Dancer 2 #1

wants to merge 1 commit into from

Conversation

mokko
Copy link

@mokko mokko commented Nov 30, 2012

I thought I check if I can translate anything from D1 to D2 and then thought of Dancer::Tutorial next. It almost runs under D2 as is, except for the template default tags [% %].

I thought I suggest a new branch for D2, but Github lets me make a PR only into the existing branch which doesn't really make sense here. Thought we keep two different branches for D1 and D2. Anyways, please have a look, change it etc.

I could also make a PR for the D2's Dancer::Tutorial.pod once you're done and if you don't want to do it yourself.

Sorry for the whitespace changes. I hope you have perltidy at hand to re-format to whatever you were using earlier. (Perhaps include .perltidyrc in repository?)

@jadeallenx
Copy link

I think this is a great idea, but I think it would be best if it was implemented as its own separate tutorial. (Perhaps something as unoriginal as "Dancer2::Tutorial"? I'm terrible at naming things.)

We could then put a pointer in the POD/README.md so people who are looking for the "Dancer 2" translation could easily find your edits.

Does that sound reasonable?

@bigpresh
Copy link
Member

bigpresh commented Dec 1, 2012

@mrallen1 I'm not sure - if it works as-is with the exception of configuring which template tags to use, it might be nice to keep it as one, so we can point to it as "look, there's the example tutorial app - works fine with both Dancer versions" :)

@mokko
Copy link
Author

mokko commented Dec 1, 2012

My goal was to show case best practices in tutorial and it seems that best practices have changed. I think best practices will be more important in the long run than compatibility between D1 and D2. But whatever Bigpresh decides is fine with me.

@jadeallenx
Copy link

@bigpresh Yeah I see that and it is pretty cool. So maybe it is a good idea. I don't have a strong objection if you think its a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants