Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace File::Find with Path::Tiny #1610

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Replace File::Find with Path::Tiny #1610

merged 5 commits into from
Apr 15, 2021

Commits on Mar 23, 2021

  1. Replace File::Find with Path::Tiny. 

    "The journey of a thousand miles begins with a single step." We have
discussed migrating to Path::Tiny (and started, see #1264 and #1544 for
details), and this is the first concrete, discrete step in doing so. It
takes a problem of small scope (app scaffolding and File::Find) to set
the stage for the rest of the migration.

There are a few TODO items here, and if there are better ways to handle
them, I am all ears. If not, I will remove my comments when I merge.

Feedback welcome/needed!
    @cromedome
    cromedome committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    e275aa0 View commit details
    Browse the repository at this point in the history

  2. Remove Data::Printer.

    @cromedome
    cromedome committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    f782270 View commit details
    Browse the repository at this point in the history

  3. Cleanup/improvement of Path::Tiny based code. 

    @SysPete had a ton of useful feedback here for #1610. All incorporated.
    @cromedome
    cromedome committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    2a7679c View commit details
    Browse the repository at this point in the history

  4. Replace child() with a list to path.

    @cromedome
    cromedome committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    5d2f049 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Don't assume we already have a Path::Tiny object.

    @cromedome
    cromedome committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    41467d3 View commit details
    Browse the repository at this point in the history