Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perfer X-Forwarded-Proto to prevent users lying #1367

Merged
merged 1 commit into from
Aug 14, 2017

Commits on Aug 1, 2017

  1. perfer X-Forwarded-Proto to prevent users lying

    X-Forwarded-Proto should be the preferred header to used to check if the
    front end connection was HTTPS.  Proto is the de facto standard for
    this, and is recommended in the deployment documentation.
    
    If the -Protocol header is checked first, that means most setups that
    only add a -Proto header will pass through a user provided -Protocol
    header, allowing users to lie about the protocol used.
    
    Ideally this would only check one header, and the reverse proxy would be
    required to send that header.  Leaving this with the fallback behavior
    for now for backwards compatibility.
    haarg committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    03d89b4 View commit details
    Browse the repository at this point in the history