Eng 1221 ps80 add triggers for ps81 minitests and package tests #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panchal-yash
requested review from
mchawla16,
eleo007,
mohitj1988,
kaushikpuneet07 and
a team
as code owners
Add git diff check for package-testing VERSION file modification for error free re-run of the build job during VERSION file commit (Similar to PXB80 setup)
panchal-yash
force-pushed
the
ENG-1221-ps80-add-triggers-for-ps81-minitests-and-package-tests
branch
from
d6ae827
to
77c5aba
Compare
EvgeniyPatlan
requested changes
Nov 23, 2023
Comment on lines
+125
to
+137
| if ("${PS8_RELEASE_VERSION}") { // Checks if PS8_RELEASE_VERSION is not empty | ||
| echo "MAJOR VERSION IS ${PS8_RELEASE_VERSION}" | ||
|
|
||
| if("${PS8_RELEASE_VERSION}" == "8.0"){ | ||
| ps80_install_pkg_minitests_playbook = 'ps_80.yml' | ||
| PS8_RELEASE_VERSION_PRODUCT_TO_TEST = 'ps80' | ||
| } | ||
| else if("${PS8_RELEASE_VERSION}" == "8.1" ){ | ||
| ps80_install_pkg_minitests_playbook = 'ps_81.yml' | ||
| PS8_RELEASE_VERSION_PRODUCT_TO_TEST = 'ps81' | ||
| } | ||
| } | ||
| else{ |
There was a problem hiding this comment.
So on each new release you are going to add additional if-block?
maybe we should reuse value from PS8_RELEASE_VERSION variable?
Comment on lines
+791
to
+800
| if [[ "${PS8_RELEASE_VERSION}" == "8.0" ]]; then | ||
| OLD_REV=\$(cat VERSIONS | grep PS80_REV | cut -d '=' -f2- ) | ||
| OLD_VER=\$(cat VERSIONS | grep PS80_VER | cut -d '=' -f2- ) | ||
| sed -i s/PS80_REV=\$OLD_REV/PS80_REV='"'${REVISION}'"'/g VERSIONS | ||
| sed -i s/PS80_VER=\$OLD_VER/PS80_VER='"'${PS_RELEASE}'"'/g VERSIONS | ||
| elif [[ "${PS8_RELEASE_VERSION}" == "8.1" ]];then | ||
| OLD_REV=\$(cat VERSIONS | grep PS81_REV | cut -d '=' -f2- ) | ||
| OLD_VER=\$(cat VERSIONS | grep PS81_VER | cut -d '=' -f2- ) | ||
| sed -i s/PS81_REV=\$OLD_REV/PS81_REV='"'${REVISION}'"'/g VERSIONS | ||
| sed -i s/PS81_VER=\$OLD_VER/PS81_VER='"'${PS_RELEASE}'"'/g VERSIONS |
There was a problem hiding this comment.
the same. one more block on each release. It is better to unify it.
| else | ||
| echo "There are changes" | ||
| git add -A | ||
| git commit -m "Autocommit: add ${REVISION} and ${PS_RELEASE} for ps80 ${PS8_RELEASE_VERSION} package testing VERSIONS file." |
Comment on lines
+818
to
+820
| if("${mini_test_error}" == "True"){ | ||
| echo "NOT TRIGGERING PACKAGE TESTS AND INTEGRATION TESTS DUE TO MINITEST FAILURE !!" | ||
| }else{ |
There was a problem hiding this comment.
why do we need this block?
just compare with False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.