Add a job for creating on demand OpenShift clusters #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hors
requested changes
May 25, 2023
hors
requested changes
May 25, 2023
| stage('cluster1') { | ||
| steps { | ||
| createCluster('cluster1') | ||
| sleep(time:"${params.CLUSTER_DURATION}",unit:"HOURS") |
There was a problem hiding this comment.
What if the spot instance dies? Who will remove the cluster?
There was a problem hiding this comment.
nobody, just like in our normal tests
There was a problem hiding this comment.
as a solution we can use jenkins master for running these jobs or specify non spot instances (pricier)
There was a problem hiding this comment.
@tplavcic The difference is you can run it for 12 hours and spot will have more time to die. I suggest to have https://cloud.cd.percona.com/job/pxc-operator-aws-remove-openshift officially
ademidoff
requested review from
ptankov,
jvpasinatto and
eleo007
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.