Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ARM64 and musl and fix few mistakes #3

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Add support for ARM64 and musl and fix few mistakes #3

wants to merge 18 commits into from

Conversation

vladmovchan
Copy link

  • Add support for musl C library
  • Import recent version of linux_syscall_support.h from google-breakpad and add ARM64 architecture support
  • Multiple fixes in parsing/saving vDSO segments
  • Make it possible for non-amd64 platforms to pass coredumper_unittest

Vladyslav Movchan added 18 commits April 26, 2021 14:44
Address different header files location in case of musl
a79c5f7 
Musl doesn't provide a way of explicitly identifying it, so find it
implicitly as "not glibc and not uclibc".
Define data types which are missing in musl
2f24a12
There is no __getpagesize() in musl, but existing getpagesize() should
9a5375b 
provide the same result
There is no bits/wordsize.h header in musl
37f009e
Include linux/time.h for musl where timespec data type is defined
5675267 
explicitly

This is necessary to address the following error with musl C library:
error: invalid application of 'sizeof' to incomplete type
'linux_syscall_support::timespec'
Skip stat64 and fstat64 if they are macros and not functions
c7d723b 
This is necessary to prevent creation of conflicting function
declarations in case of musl C library.
Make it possible for non-amd64 platforms to pass coredumper_unittest
4e48b75
Import the recent version of linux_syscall_support.h from
5c5bd97 
google-breakpad
Adapt according to changed sys_prctl() definition
309e35d
Restore sys__sigprocmask wrapper used in linux_syscall_support_unittest
f5602a1
Add missing aarch64 bits
ed6f481
Add aarch64 support
323aa6d
Correct waitpid wstatus argument type
be9e560
Add missing header for getpid()
c0283a0
PT_LOAD segment might not always go first
b0b9495
Interpret p_vaddr as an offset rather than absolute address
08883d9
Correct check for proper alignment
cb6ddc3
Skip PT_NOTE segment obtained from vDSO
9bfd72b 
There should be just one PT_NOTE segment in a core file.
And otherwise gdb identify such core file as corrupted.
@dutow dutow self-requested a review January 10, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutow dutow Awaiting requested review from dutow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vladmovchan