Increase plaintext&hash login speeds #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeffIsBack
requested review from
zblurx,
Marshall-Hallenbeck and
mpgn
as code owners
mpgn
reviewed
Aug 30, 2024
mpgn
reviewed
Aug 30, 2024
mpgn
reviewed
Aug 30, 2024
mpgn
previously approved these changes
Sep 1, 2024
Mercury0
added a commit
to Mercury0/NetExec
that referenced
this pull request
Sep 12, 2024
NetExec PR Pennyw0rth#411 Signed-off-by: Mercury0 <[email protected]>
mpgn
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary recreation of connection initialization when a login has failed, we can just reuse that smb connection. As we don't need it with kerberos (and it would be a bit more complicated) it is not changed.
Also
create_conn_obj()now checks if we already tested smbv1 and will choose the version accordingly for further connections, to eliminate the amount of connections.This results in double the speed when testing credentials:
Before (tested with a wordlist containing ~3,6k lines):
After: