[wmi] bug fix in 'check_admin' function #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: XiaoliChan <[email protected]>
Signed-off-by: XiaoliChan <[email protected]>
|
Since @mpgn merged my PR, we don't need to switch to my fork |
|
The original function is best, don't think needs to improve anymore, has bugs after improve the function |
XiaoliChan
changed the title
Signed-off-by: XiaoliChan <[email protected]>
XiaoliChan
force-pushed
the
wmi-improv-admin-check
branch
from
ffec068
to
20459ef
Compare
Signed-off-by: XiaoliChan <[email protected]>
|
@XiaoliChan is the poetry.lock change needed? I'm sorta confused with that one. |
Yes, it’s needed, some dcom bugs in latest version mpgn’s impacket fork |
XiaoliChan
requested review from
zblurx,
Marshall-Hallenbeck and
NeffIsBack
as code owners
Marshall-Hallenbeck
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcom.disconnect()function and addeddcom.set_connect_timeout()dcom.set_connect_timeout()Reference: