Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ssh] Improvement #3

Closed
wants to merge 3 commits into from
Closed

[ssh] Improvement #3

wants to merge 3 commits into from

Conversation

XiaoliChan
Copy link
Contributor

  • Rewrite SSH protocol
  • Bring up Linux sudo check and Windows admin check

@XiaoliChan
[ssh] improvement
e85db1c 
Signed-off-by: XiaoliChan <[email protected]>
@XiaoliChan XiaoliChan changed the title [ssh] improvement [ssh] Improvement Sep 9, 2023
@NeffIsBack NeffIsBack added the enhancement New feature or request label Sep 9, 2023
@Marshall-Hallenbeck
Copy link
Collaborator

Marshall-Hallenbeck commented Sep 9, 2023 •
edited
Loading

I'll check this out and give some feedback.

@XiaoliChan are all changes done for this PR?

@XiaoliChan
Copy link
Contributor Author

I'll check this out and give some feedback.

@XiaoliChan are all changes done for this PR?

Yes !

@Marshall-Hallenbeck
Copy link
Collaborator

@XiaoliChan which OSes and versions did you test this against, and what sort of user privs (sudo no password, etc)

@XiaoliChan
Copy link
Contributor Author

XiaoliChan commented Sep 17, 2023 •
edited
Loading

@XiaoliChan which OSes and versions did you test this against, and what sort of user privs (sudo no password, etc)

For linux, I test with openwrt, debian, Kali Linux
For windows, I test with server 2019
For others device, I test with netgear switch

@XiaoliChan
[ssh] up to date
77891e3 
Signed-off-by: XiaoliChan <[email protected]>
@XiaoliChan XiaoliChan closed this Sep 18, 2023
@XiaoliChan XiaoliChan deleted the ssh-improv branch September 18, 2023 08:25
@XiaoliChan XiaoliChan mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marshall-Hallenbeck Marshall-Hallenbeck Awaiting requested review from Marshall-Hallenbeck Marshall-Hallenbeck is a code owner

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

@NeffIsBack NeffIsBack Awaiting requested review from NeffIsBack NeffIsBack is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request requires testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XiaoliChan @Marshall-Hallenbeck @NeffIsBack