Reduce third party debug logging #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instead of DEBUG when --debug is set
Marshall-Hallenbeck
requested review from
zblurx,
NeffIsBack and
mpgn
as code owners
|
Do you have a before&after for the bug fix? |
|
It's in the initial message @NeffIsBack |
Spoke with @NeffIsBack about this - he meant the bugfix I referenced, which is this line: https://github.com/Pennyw0rth/NetExec/pull/290/files#diff-e9ef40513b31bc1fbcadcc3400cf6e6148782623051421322e22fff1bd574861R57 I didn't include a picture, but essentially we received debug logs for #288 where the exception message was actually being triggered inside the Python logging library because for some reason the exception data wasnt being filled in, even though the error message existed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of annoying useless logs being shown since we set the global logger to
DEBUG. This sets the global logger higher, but keeps ours dependent on what the user specifies.This also fixes a weird error noticed in #288 where the exception data wasn't being populated during debugging, so I added a check to make sure that its set, and if it's not, set it to the error message (which is what it should be).
Before, with a lot of annoying useless stuff:
After:
