Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write out correlations when --create-matrices doesn't include "all" #1326

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Nov 18, 2024

Closes none, but addresses a bug identified in https://neurostars.org/t/filenotfounderror-no-bold-data-found-in-allowed-spaces-fslr/30968.

Changes proposed in this pull request

  • Set config.execution.output_correlations to True when exact scans are provided through --create-matrices, but "all" is not included.

@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Nov 18, 2024
@tsalo tsalo changed the title Write out correlations when --create-matrices doesn't include all Write out correlations when --create-matrices doesn't include "all" Nov 18, 2024
@tsalo
Copy link
Member Author

tsalo commented Nov 18, 2024

It looks like this might require a bit more thought.

@tsalo tsalo self-assigned this Nov 18, 2024
@tsalo
Copy link
Member Author

tsalo commented Nov 19, 2024

Maybe I can just force dcan_correlation_lengths to be ["all"] for linc mode and drop output_correlations?

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (e19b7b1) to head (ff1308f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/workflows/bold/concatenation.py 0.00% 7 Missing and 1 partial ⚠️
xcp_d/workflows/bold/connectivity.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1326      +/-   ##
==========================================
- Coverage   79.03%   78.96%   -0.08%     
==========================================
  Files          59       59              
  Lines        7408     7406       -2     
  Branches      961      962       +1     
==========================================
- Hits         5855     5848       -7     
- Misses       1261     1268       +7     
+ Partials      292      290       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@tsalo tsalo merged commit 0e07ef1 into PennLINC:main Nov 20, 2024
22 of 24 checks passed
@tsalo tsalo deleted the fix-output-correlations branch November 20, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant