-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept external atlases by searching BIDS-Atlas datasets #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
+ Coverage 78.63% 78.80% +0.16%
==========================================
Files 59 59
Lines 7308 7360 +52
Branches 1106 1136 +30
==========================================
+ Hits 5747 5800 +53
+ Misses 1273 1267 -6
- Partials 288 293 +5 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 2, 2024
Tests are passing, coverage is up, and the new behavior is documented, so I think we're good to go! |
tsalo
changed the title
Accept BIDS-Atlas datasets as atlases
Accept external atlases by search BIDS-Atlas datasets
Oct 4, 2024
tsalo
changed the title
Accept external atlases by search BIDS-Atlas datasets
Accept external atlases by searching BIDS-Atlas datasets
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1226.
Allow users to provide paths to BIDS-Atlas datasets via the --datasets (renamed from --derivatives) parameter, as well as names of atlases in those datasets via the --atlases parameter.
Atlases need to be in fsLR-32k space (for CIFTI processing) or MNIInfant/MNI152NLin6Asym/MNI152NLin2009cAsym space (for NIfTI processing). This space/resolution limitation is hopefully only temporary, since I ultimately want to accept almost any input space. See #1076.
Changes to inputs
Changes to outputs
atlases
dataset) now share all of the same entities as the image file. Before they only had the atlas entity.Internal changes
xcpd_build
).