-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring outputs up to date with BEPs 11, 12, 17, and 38 #1065
Conversation
Keeping atlas for the actual atlases.
yeah right
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
+ Coverage 82.29% 82.44% +0.15%
==========================================
Files 48 48
Lines 5897 5925 +28
Branches 803 812 +9
==========================================
+ Hits 4853 4885 +32
+ Misses 844 841 -3
+ Partials 200 199 -1 ☔ View full report in Codecov by Sentry. |
@mattcieslak @kahinimehta would you mind taking a look at the new filenames some time next week to see if they align with your understanding to the relevant BEPs? |
Update outputs.rst Update output documentation. Fix *another* bug. Update outputs.py Update outputs.py Update bids.py Update expected outputs. Add atlases dataset link. Add dataset_description.json for atlases. Use BIDS-URI for correlation matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these BEPs a lot. The new output names I think make sense and are more technically correct than before. Awesome work
This reverts commit 373a1f1.
Changes proposed in this pull request
conmat
torelmat
. Proposed in BEP 017.conmat
toboldmap
. Proposed in BEP 012.measure
entity withstat
. Currently planned in BEP 017.alff
,reho
, andcoverage
suffixes withstat-<alff|reho|coverage>_bold[map]
, based on BEP 012. Closes Rename ALFF and ReHo outputs based on BEP 012 #971.References
Documentation that should be reviewed