Change T1wACPC to ACPC and T1wNative to anat

[tsalo]

Closes #853 and closes #854.

Changes proposed in this pull request

• Rename T1wACPC space value to ACPC.
  • In several cases, T1w is used where ACPC is meant.
  • In some cases, no space entity was used where ACPC was more appropriate.
• Rename T1wNative space value to anat.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.57%. Comparing base (0e21c37) to head (cb44ca5).
Report is 6 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   28.57%   28.57%           
=======================================
  Files          68       68           
  Lines       10126    10126           
  Branches     1135     1135           
=======================================
  Hits         2893     2893           
  Misses       7134     7134           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattcieslak]

Only a few questions

[mattcieslak]

looks good to go!

[tsalo]

Something went wrong with the filename patterns for desc-slice_qc. I'll look into it tomorrow.

[tsalo]

I always assumed that the filename patterns in the DerivativesDataSink were selected based on the number of matching entities, but I guess the order of patterns in the list actually matters. Moving the "bad" pattern to the end of the list seems to fix the problem.

[tsalo]

It's finally passing. @mattcieslak could you take one more look before we merge?

[mattcieslak]

I can add those small docs changes to a different PR

[tsalo]

Thanks! I'll merge once CI passes then.