Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy common meta data from page to PDF #35

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

phurni
Copy link

@phurni phurni commented Oct 23, 2021

Problem

Common meta-data of the generated PDF are blank, these includes title, author, subject.
These meta data may be available in the original HTML page.

Solution

Grab these meta data from the HTML page if they exists and set them in the resulting PDF.

Copy link
Owner

@PejmanNik PejmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. can you please change the code in order to get this info on one page.evaluate as an object. I think it will impact the performance and it can be cleaner code.
Thank you

@phurni phurni requested a review from PejmanNik May 25, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants