Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLDSIG.js requires/imports asn1js but doesn't depend on it in package.json #8

Open
moll opened this issue May 3, 2017 · 2 comments

Comments

@moll
Copy link

moll commented May 3, 2017

A sister issue to PeculiarVentures/xadesjs#50. Unless I'm messing something up on my side, I suspect you were using NPMv3 to build this thing as it defaults to installing dependencies in a single directory thereby being very lenient of forgotten dependency declarations. 8-)

@microshine
Copy link
Collaborator

Asn1js is dependency of pkijs.
What is your version of npm?

@moll
Copy link
Author

moll commented May 3, 2017

From what I can tell https://github.com/PeculiarVentures/xmldsigjs/blob/c8177e06bb6001582d4369565d2a070b5e42098d/src/pki/x509.ts imports (aka requires) Asn1js directly thereby depending on it, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants