<X509SerialNumber /> not an integer

[moll]

Hey,

Just a heads up that I too stumbled upon an issue with certificate serial numbers getting serialized in hex where they should be integers and noticed there's even a related TODO line (https://github.com/PeculiarVentures/xadesjs/blob/master/src/signed_xml.ts#L141) about. Docs signed with certs with such serial numbers obviously fail to validate outside of Xades.js. :)

[moll]

Then again, this bug may be in Xmldsig.js. Not sure which bit does what here yet. ;)

[microshine]

@moll Thank you for your issue. I'm waiting for new update of asn1.js which must allow to convert INTEGER values to BIG number. This update must resolve current problem

[moll]

Cool. Do you reckon there's any risk or unintended side-effect if I overwrite Xmldsig.X509Certificate.SerialNumber and have it return a string of a big number in the meanwhile?

[microshine]

I thought about bn.js module to fix this error. But developer of asn1.js told me that he support INTEGER conversion to BIG NUMBER in 1 or 2 days.
And you are right. We have to update Xmldsig.X509Certificate.SerialNumber. I don't see any risk of changing this. There can be also added converter for SerialNumber attribute to check correct integer data.

[YuryStrozhevsky]

Now we the latest changes in ASN1.js and pvutils you would be able to get string representation like this:

const serialNumberRepresentation = certificate.serialNumber.valueBlock.toString();

Integer could be arbitrary in length.

[microshine]

I published new versions of xmldsigjs and xadesjs. It returns integer in <SerialNumber>
@moll Could you check it?

[moll]

Will do. Thank you! Did you fix the dependency bugs in those two, too, that I reported in other issues?

[microshine]

no, I didn't

[moll]

However PeculiarVentures/xmldsigjs@d9c2f90 seems to indicate you did fix PeculiarVentures/xmldsigjs#8. ;)

[moll]

Having said that, you're right, xml-core is still missing as per #50.