react-components: Add Autocomplete component #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarikTar
changed the base branch from
main
to
mariktar/add-pv-designe-system-autocompleate
…//github.com/PeculiarVentures/peculiar-ui into mariktar/add-new-autocoplete-component
Base automatically changed from
mariktar/add-pv-designe-system-autocompleate
to
main
September 26, 2024 16:34
…into mariktar/add-new-autocoplete-component
MarikTar
force-pushed
the
mariktar/add-new-autocoplete-component
branch
from
f5beeae
to
2667d50
Compare
…into mariktar/add-new-autocoplete-component
…/add-new-autocoplete-component' of https://github.com/PeculiarVentures/peculiar-ui into mariktar/add-new-autocoplete-component
donskov
requested changes
Sep 30, 2024
| @@ -525,6 +527,20 @@ Multiple extends boolean | undefined = false, | |||
| selectNewValue(event, option, index, 'removeOption'); | |||
| }; | |||
|
|
|||
| const handleDeleteAllValues = (event: React.SyntheticEvent) => { | |||
There was a problem hiding this comment.
Let's use the getClearProps instead and group clear props together.
| * | ||
| */ | ||
|
|
||
| export const Autocomplete = < |
There was a problem hiding this comment.
Check the clear button. There is in the mockups, but there is no implementation.
| className, | ||
| size, | ||
| placeholder, | ||
| label, |
There was a problem hiding this comment.
Something happened with the field label. Clicking on the label does not focus the field.
| size, | ||
| placeholder, | ||
| label, | ||
| disabled = false, |
There was a problem hiding this comment.
Turning off the component (disabled=true) also has no effect. The component is not blocked and continues to work.
donskov
requested changes
Sep 30, 2024
| } | ||
| }; | ||
|
|
||
| const handleKeyDown = (event: React.KeyboardEvent<HTMLDivElement>) => { |
There was a problem hiding this comment.
When the tab is used, the component menu opens and stops working with the keyboard.
Reproduce:
- Make sure that the component is not in focus, click on tab. The component must be in focus.
- Click the tab again. The component menu opens, the focus disappears and the component itself does not respond to other keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new Autocomplete component